-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dashboard filter modal should not be available in small screen #1567
Conversation
const filter = { | ||
id: 'ponies', | ||
name: 'Ponies', | ||
values: [{ name: 'Rainbow Dash' }, { name: 'Twilight Sparkle' }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I finally know who added all of the my little pony names to DV 🦄 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦄
## [31.12.7](v31.12.6...v31.12.7) (2021-02-25) ### Bug Fixes * dashboard filter modal should not be available in small screen ([#1567](#1567)) ([53db918](53db918))
🎉 This PR is included in version 31.12.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Adds a separate element in the FilterBadge for small screen that does not have the click action, so that the filter modal cannot be opened while in small screen. (video not included, but the cypress tests covers the scenario)
2 new cypress tests added - one where it is possible to open the filter modal, and one where it isn't possible.
Jest unit test added to check that Filter badge has the correct text on it.